Core Contracts

Summary

The category allocations (precisely categoryAllocations mapping) is utilised for the sake of storing allocation amounts for different categories within the RAACReleaseOrchestrator.sol contract.

Vulnerability Details

The team allocates extremely high ether numbers which are wrong. For instance, the TEAM_CATEGORY allocation is 18_000_000 ether, which equates to almost $50 billion at todays current ETH price.

To put this into perspective, the overall number of all categoryAllocations combined, with todays current ETH rate @ 2679.42, is:

• Team Category: $48,229,560,000.00

• Advisor Category: $27,598,026,000.00

• Treasury Category: $13,397,100,000.00

• Private Sale Category: $26,794,200,000.00

• Public Sale Category: $40,191,300,000.00

• Liquidity Category: $18,220,056,000.00

• Total: $174,430,242,000.00

Impact

Wrong accounting of categoryAllocations, which affects functions such as createVestingSchedule where we check if the newCategoryTotal is more than the categoryAllocations[category]. This would mean every check is skewed and completely out of range constantly.

Also affects getCategoryDetails() and getTotalAllocation.

Tools Used

Manual review

Recommendations

Correctly assign the values relative to the percentages as intended.