Core Contracts
Regnum Aurum Acquisition Corp
HardhatReal World AssetsNFT
77,280 USDC
View results
Previous Next
Submission Details
Severity: low
Valid

fees in ``FeeCollector.sol::_initializeFeeTypes()`` are higher

makriss

Summary

feeTypes[6] and feeTypes[7], for Buy/Sell Swap Tax and NFT Royalty Fees are 2% but they take 20%

Vulnerability Details

FeeCollector.sol::_initializeFeeTypes(): https://github.com/Cyfrin/2025-02-raac/blob/main/contracts/core/collectors/FeeCollector.sol#L330

the Percentage calculation represented by BASIS_POINTS = 10000 which is 100%
https://github.com/Cyfrin/2025-02-raac/blob/main/contracts/core/collectors/FeeCollector.sol#L91

so 10000 = 100% and 1000 = 10% and 100 = 1% and 10 = 0.1%

but here 1000 represented by 1% and 500 by 0,5% which is false

// Buy/Sell Swap Tax (2% total)
feeTypes\[6] = FeeType({
veRAACShare: 500, // 0.5%
burnShare: 500, // 0.5%
repairShare: 1000, // 1.0%
treasuryShare: 0
});
​
// NFT Royalty Fees (2% total)
feeTypes[7] = FeeType({
veRAACShare: 500, // 0.5%
burnShare: 0,
repairShare: 1000, // 1.0%
treasuryShare: 500 // 0.5%
});

Impact

it takes 10x more fees

Tools Used

Manual Review

Recommendations

remove the wrong numbers and write the correct one

Updates

Lead Judging Commences

inallhonesty Lead Judge 7 months ago
Submission Judgement Published
Validated
Assigned finding tags:

Fee shares for fee type 6 and 7 inside FeeCollector do not total up to the expected 10000 basis points, this leads to update problems, moreover they are 10x the specifications

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!