Core Contracts
Regnum Aurum Acquisition Corp
HardhatReal World AssetsNFT
77,280 USDC
View all submissions
Previous Next
Submission Details
Severity: high
Valid

function `distributeRewards` is not making transfer it is only notifying .

Author Revealed upon completion

Summary

In contract GaugeController.sol function distributeRewards is not making the transfer . it is only notifying the the rewards is distributed .

Vulnerability Details

In contract GaugeController.sol function distributeRewards is not making the transfer . it is only notifying the the rewards is distributed .

IGauge(gauge).notifyRewardAmount(reward); // q did we transfered the reward or we just notify the reward amount .
emit RewardDistributed(gauge, msg.sender, reward);
​
/**
* @notice Distributes rewards to a gauge
* @dev Calculates and transfers rewards based on gauge weight
* @param gauge Address of gauge to distribute rewards to
*/
function distributeRewards(
address gauge
) external override nonReentrant whenNotPaused {
if (!isGauge(gauge)) revert GaugeNotFound();
if (!gauges[gauge].isActive) revert GaugeNotActive();
uint256 reward = _calculateReward(gauge);
if (reward == 0) return;
IGauge(gauge).notifyRewardAmount(reward); // q did we transfered the reward or we just notify the reward amount .
emit RewardDistributed(gauge, msg.sender, reward);
}
​

Impact

  1. Rewards transfer will not happen and it willl emit that the reward is distributed .

Tools Used

Manual Review

Recommendations

  1. Add the transfer functionality in it which will transfer the rewards .

Updates

Lead Judging Commences

inallhonesty Lead Judge 12 days ago
Submission Judgement Published
Validated
Assigned finding tags:

GaugeController notifies gauges of rewards without transferring tokens in both distributeRewards and _distributeToGauges functions, breaking reward distribution

inallhonesty Lead Judge 12 days ago
Submission Judgement Published
Validated
Assigned finding tags:

GaugeController notifies gauges of rewards without transferring tokens in both distributeRewards and _distributeToGauges functions, breaking reward distribution

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.