Core Contracts

Summary

Attacker to claim rewards from the raacGauge contract without staking or voting on the gauge. This is due to the permissionless nature of the distributeRewards function, which can be called by any user, including malicious actors. By calling distributeRewards and waiting for other users to stake and vote, an attacker can claim rewards without contributing to the system.

Vulnerability Details

1. Permissionless distributeRewards Function:

   • The distributeRewards function in the gaugeController contract is permissionless, meaning any user (e.g., user1) can call it.

   • This function initiates the distribution of rewards to the raacGauge contract.

2. Attacker's Workflow:

   • The attacker (user1) calls distributeRewards to fund the raacGauge with rewards.

   • After calling distributeRewards, the attacker waits for legitimate users (e.g., user2) to stake tokens and vote on the gauge.

   • Once the reward distribution period is over, the attacker calls raacGauge.getReward() to claim rewards without having staked or voted.

Impact

The attacker receives free rewards without contributing to the system (i.e., without staking or voting). This undermines the fairness of the reward distribution mechanism and could lead to significant financial losses for legitimate users.

Tools Used

Manual Review

POC

Recommendations

1. Restrict Access to distributeRewards:

   • Ensure that only authorized addresses (e.g., the contract owner or a dedicated reward distributor) can call distributeRewards.

   • Example:

     solidity

     Copy

     modifier onlyOwner() {

     require(msg.sender == owner, "Unauthorized");

     _;

     }

     ​

     function distributeRewards(address gauge) public onlyOwner {

     // Reward distribution logic

     }

2. Require Staking or Voting to Claim Rewards:

   • Modify the getReward function to ensure that only users who have staked tokens or voted on the gauge can claim rewards.

   • Example:

     solidity

     Copy

     function getReward() public {

     require(stakedBalances[msg.sender] > 0 || votes[msg.sender] > 0, "No staking or voting");

     // Reward claim logic

     }

3. Track User Contributions:

   • Implement a mechanism to track user contributions (e.g., staking and voting) and distribute rewards proportionally.

   • Example:

     solidity

     Copy

     mapping(address => uint256) public stakedBalances;

     mapping(address => uint256) public votes;

     ​

     function getReward() public {

     uint256 userStake = stakedBalances[msg.sender];

     uint256 userVotes = votes[msg.sender];

     require(userStake > 0 || userVotes > 0, "No contribution");

     uint256 reward = calculateReward(userStake, userVotes);

     // Transfer reward to user

     }