Submission Details
Severity:
Repay is pausable, which may prevent users from repaying their debt while the collateral price declines.
Summary
Both repay and repayOnBehalf are pausable. If the protocol is paused while the collateral price drops, users will be unable to repay their debt, potentially leading to liquidation once the protocol is unpaused.
Vulnerability Details
function repay(uint256 amount) external nonReentrant whenNotPaused onlyValidAmount(amount) { //@audit repay func can not be paused or user can't repay assets when paused.
_repay(amount, msg.sender);
}
function repayOnBehalf(uint256 amount, address onBehalfOf) external nonReentrant whenNotPaused onlyValidAmount(amount) {
if (!canPaybackDebt) revert PaybackDebtDisabled();
if (onBehalfOf == address(0)) revert AddressCannotBeZero();
_repay(amount, onBehalfOf);
}
From above code we can see both function is pauseable.
Impact
User will be unable to repay their debt
Tools Used
Foundry
Recommendations
Delete whenNotPaused in repay and repayOnBehalf functions
Prize pool breakdown
Total prize
77,280 USDC
nSLOC
3,86420 USDC / LOC
74,000
3,280
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.