`collectFee` in FeeCollector contract is not integrated in the protocol, preventing protocol components to send their accumulated fees.
Summary
collectFee in FeeCollector contract is the function responsible for transferring fees generated by the various components of the protocol to the fee collector.
The issue arises because none of the protocol components integrate this function in their fee mechanism. Actually, these components don't even implement a fee logic (lending pool, NFT minting, etc). Regarding RAAC Token, there is a fee logic but fees are directly transferred to the FeeCollector which is in incorrect.
Impact
The impact of this issue is high as it leads to fees never sent to the fee collector.
Tools Used
Manual review
Recommendations
Make sure to integrate collectFee into all components of the protocol that will generate fees in order to collect them.
Lead Judging Commences
RAACToken::burn sends tax directly to FeeCollector without using collectFee(), causing tokens to bypass accounting and remain undistributed. `collectFee` is not used anywhere.
RAACToken::burn sends tax directly to FeeCollector without using collectFee(), causing tokens to bypass accounting and remain undistributed. `collectFee` is not used anywhere.
Prize pool breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.