Submission Details
Severity:
Anyone can call recordVote function for others
Summary
Any user can call recordVote() in veRAACToken.sol for other users
Vulnerability Details
e.g.
Alice can set that Bob has already vote on this proposal
function recordVote(address voter, uint256 proposalId) external {
//@audit malicoius user can call it on behalf of other user
if (_hasVotedOnProposal[voter][proposalId]) revert AlreadyVoted();
_hasVotedOnProposal[voter][proposalId] = true;
uint256 power = getVotingPower(voter);
emit VoteCast(voter, proposalId, power);
}
there is no check if the msg.sender == user
Impact
Malicious users can grief the clients
Tools Used
Recommendations
Make a check if the msg.sender == user if not revert
Updates
Lead Judging Commences
inallhonesty about 1 month ago
Submission Judgement Published Assigned finding tags:
veRAACToken::recordVote lacks access control, allowing anyone to emit fake events
Prize pool breakdown
Total prize
77,280 USDC
nSLOC
3,86420 USDC / LOC
74,000
3,280
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.