Submission Details
Severity:
The buy/sell and NFT royalty fees are charged incorrectly
Summary
The buy/Sell and NFT Royalty Fees in the fee collector are charged incorrectly.
Vulnerability Details
The NFT Royal fees and the Buy/Sell swap tax are applied incorrectly
// Buy/Sell Swap Tax (2% total)
feeTypes[6] = FeeType({
@> veRAACShare: 500, // 0.5%
@> burnShare: 500, // 0.5%
@> repairShare: 1000, // 1.0%
treasuryShare: 0
});
// NFT Royalty Fees (2% total)
feeTypes[7] = FeeType({
@> veRAACShare: 500, // 0.5%
burnShare: 0,
@> repairShare: 1000, // 1.0%
@> treasuryShare: 500 // 0.5%
});
The 500 as 0.5% is wrong, it should be 50 instead of the 500, the same with 1000 as 1.0%, this is also incorrect, it should be 100 and not the 1000
Impact
The fees would be overcharged due to wrong application.
Tools Used
Manual review
Recommendations
Change it to something like this
// Buy/Sell Swap Tax (2% total)
feeTypes[6] = FeeType({
+ veRAACShare: 50, // 0.5%
+ burnShare: 50, // 0.5%
+ repairShare: 100, // 1.0%
treasuryShare: 0
});
// NFT Royalty Fees (2% total)
feeTypes[7] = FeeType({
+ veRAACShare: 50, // 0.5%
burnShare: 0,
+ repairShare: 100, // 1.0%
+ treasuryShare: 50 // 0.5%
});
Updates
Lead Judging Commences
inallhonesty 5 months ago
Submission Judgement Published Assigned finding tags:
Fee shares for fee type 6 and 7 inside FeeCollector do not total up to the expected 10000 basis points, this leads to update problems, moreover they are 10x the specifications
Prize pool breakdown
Total prize
77,280 USDC
nSLOC
3,86420 USDC / LOC
74,000
3,280
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.