Submission Details
Severity:
Use ReentrancyGuardUpgradeable instead of ReentrancyGuard
Summary
The contract is designed to be upgradeable, as indicated by the use of Initializable. However the contract uses ReentrancyGuard (non-upgradeable version), which can cause storage conflicts in an upgradeable contract.
Vulnerability Details
StabilityPool.sol
contract StabilityPool is IStabilityPool, Initializable, ReentrancyGuard, OwnableUpgradeable, PausableUpgradeable {//@audit not use upgrade.
using SafeERC20 for IERC20;
using SafeERC20 for IRToken;
using SafeERC20 for IDEToken;
using SafeERC20 for IRAACToken;
Impact
ReentrancyGuard declares _status in storage, which may cause conflicts when the contract is upgraded if the storage layout changes.
Tools Used
Foundry
Recommendations
use ReentrancyGuardUpgradeable instead of ReentrancyGuard
Prize pool breakdown
Total prize
77,280 USDC
nSLOC
3,86420 USDC / LOC
74,000
3,280
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.