`mintRewards` in RAACMinter contract is never called by the StabilityPool contract although it is the only allowed caller, leading to definitive rewards distribution incapacity.
Summary
RAACMinter contract defines a mintRewards function that can only be called by the stability pool. This function allows to mint rewards if excessTokens is not enough, and then send the requested amount to a specified address.
The problem arises because this function is never called by RAACMinter contract, making it unusable.
Impact
The impact of this issue is medium as it prevents the contract from working properly. mintRewards will never be callable, whether it is by the stability pool or externally. The real purpose of this function is unclear, the stability pool seems to only need the tick function to mint RAAC rewards.
Tools Used
Manual review
Recommendations
Make sure to implement the logic in the stability pool to allow minting rewards through the RAAC Minter contract.
Lead Judging Commences
RAACMinter::mintRewards function is never called by StabilityPool despite being the only authorized caller, leaving intended reward functionality unused
RAACMinter::mintRewards function is never called by StabilityPool despite being the only authorized caller, leaving intended reward functionality unused
Prize pool breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.