Submission Details
Severity:
Missing oracle staleness checks in LendingPool:getNFTPrice()
Summary
Missing oracle staleness checks in LendingPool:getNFTPrice()
Vulnerability Details
The function invokes the RAAC oracle to obtain the latest price for a given tokenId, however the lastUpdateTimestamp parameter is unused, potentially allowing the contract to consume stale prices.
function getNFTPrice(uint256 tokenId) public view returns (uint256) {
(uint256 price, uint256 lastUpdateTimestamp) = priceOracle.getLatestPrice(tokenId); // @audit-issue no price staleness validation
if (price == 0) revert InvalidNFTPrice();
return price;
}
Impact
Consumption of stale prices which can impact user's collateralization ratio.
Tools Used
Manual Review
Recommendations
Ensure that lastUpdateTimestamp is within a certain time threshold.
Updates
Lead Judging Commences
inallhonesty 6 months ago
Submission Judgement Published Assigned finding tags:
LendingPool::getNFTPrice or getPrimeRate doesn't validate timestamp staleness despite claiming to, allowing users to exploit outdated collateral values during price drops
inallhonesty 6 months ago
Submission Judgement Published Assigned finding tags:
LendingPool::getNFTPrice or getPrimeRate doesn't validate timestamp staleness despite claiming to, allowing users to exploit outdated collateral values during price drops
Prize pool breakdown
Total prize
77,280 USDC
nSLOC
3,86420 USDC / LOC
74,000
3,280
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.