Submission Details
Severity:
[I-2] Avoid using magic numbers to enhance clarity and readability
Summary
Magic numbers are used in the code to store constants, making the code less readable. It is recommended to use constants instead.
Here are the magic numbers used in the code:
proof: DynArray[bytes32, 20] # why 20 is selected? max length?
# 31 and 69 are explained in the contract description
# but it could be more explicit as for 100 as the precision
instant_release: uint256 = (total_amount * 31) // 100
linear_vesting: uint256 = (total_amount * 69) // 100
Recommendations
Create proper constants with clear names can enhance readability:
PRECISION: uint256 = 100
TGE_RELEASE_PERCENT: uint256 = 31 # Token Generation Event
LINEAR_VESTING_PERCENT: uint256 = 69
MAX_PROOF_LENGTH: uint256 = 20
Rewards breakdown
nSLOC
127This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.