Vyper Vested Claims

First Flight #34
Beginner FriendlyDeFi
100 EXP
View results
Submission Details
Severity: low
Invalid

[I-3] Enhance safety by explicitly setting the owner address in the constructor

Summary

The owner is currently set within the VestedAirdrop::__init__ constructor using the msg.sender value. For enhanced safety, it is recommended to explicitly pass the intended owner address as an argument during contract deployment.

Impact

An incorrect deployment could inadvertently assign ownership to an unintended EOA or contract.

Recommendations

Modify the constructor to accept the owner as an argument:

- def __init__(merkle_root: bytes32, token: address, vesting_start_time: uint256, vesting_end_time: uint256):
+ def __init__(merkle_root: bytes32, token: address, vesting_start_time: uint256, vesting_end_time: uint256, owner: address):
Updates

Appeal created

bube Lead Judge 6 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.