DeFiLayer 1Layer 2
14,723 OP
View results
Submission Details
Severity: low
Invalid

No error message in require statements

Summary

_extractPeriodFromProof function calculates slot using Verifier.extractSlotValueFromProof and made a condition in require statement to verify that slot exists , and revert the transaction if slot doesn't exist but no error message in present in require.

Impact

Function reverts silently and make it difficult to understand and diagnose the issue.

Recommendations

Add an error message or custom error in the require statement

require(slot.exists, "Slot does not exist");
Updates

Lead Judging Commences

0xnevi Lead Judge 5 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

[invalid] finding-error-can-be-more-explicit

Informational, non-acceptable severity given it has arguably no security impact

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.