Submission Details
Severity:
Missing Event Emission for update_profit_max_unlock_time
Summary
The function update_profit_max_unlock_time updates a critical contract parameter (profit_max_unlock_time) but does not emit an event to track the change. This reduces transparency and makes it difficult for external monitoring tools, indexers, etc to track updates efficiently
Tools Used
Manual review
Recommendations
Emit an event to log the changes, such as:
event ProfitMaxUnlockTimeUpdated:
previous_value: uint256
new_value: uint256
block_number: uint256
Updates
Lead Judging Commences
0xnevi 3 months ago
Submission Judgement Published Assigned finding tags:
finding-missing-event-emission-profit_max_unlock_time
I believe low severity to be appropriate here, events could be used to be more explicit for the upcoming effects on price for changes in max unlock time, similar to as included in `update_price` with the `PriceUpdate` event
Prize pool breakdown
Total prize
14,723 OP
Eagles
1,472 OP
nSLOC
39437 OP / LOC
12,700
551
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.