Storage Proofs

Summary

The scrvUSD Oracle system lacks critical input validation checks, particularly for total_supply and price-related parameters. The system fails to validate critical inputs, such as ensuring that total_supply is greater than zero or that price ranges are within reasonable bounds.

Vulnerability Details

Code Locations:

• ScrvusdOracleV2.vy:

  def _raw_price(ts: uint256, parameters_ts: uint256) -> uint256:

  return self._total_assets(parameters) * 10**18 // self._total_supply(parameters, ts)

• No check for self._total_supply(...) > 0.

• ScrvusdVerifierV1.sol: Accepts state proofs without validating parameter sanity (e.g., total_supply).

  -> Missing guards for total_supply > 0 and valid price ranges.

Impact

• Division-by-Zero: If total_supply = 0, _raw_price reverts, freezing the oracle and halting pool operations.

• Systemic Risk: Entire protocol functionality depends on oracle reliability.

Tools Used

Recommendations

Input Validation:

• Add checks in ScrvusdOracleV2.vy:

  assert self._total_supply(parameters, ts) > 0, "Invalid total_supply"