Storage Proofs

Summary

The _extractParametersFromProof function iterates through a proof list to extract storage values. However, the loop does not optimize storage access and could be gas-intensive, leading to excessive transaction costs.

Vulnerability Details

• The function reads values from a storage slot list using multiple storage lookups instead of caching frequently accessed values in memory.

• Storage operations in Ethereum are costly, and repeated accesses within the loop can significantly increase gas fees.

• The loop does not use unchecked arithmetic where applicable, leading to unnecessary gas consumption.

Impact

• Excessive gas consumption, leading to high transaction fees for users interacting with the contract.

• Potential out-of-gas errors in extreme scenarios with large proofs, preventing successful price updates.

• Increased costs could make frequent price updates economically unfeasible.

Tools Used

manual review

Recommendations

• Optimize loop execution by using unchecked operations where applicable to reduce gas costs.

• Reduce redundant storage reads by caching frequently used values in memory.

• Consider batch processing techniques to minimize transaction overhead.