DeFiLayer 1Layer 2
14,723 OP
View results
Submission Details
Severity: low
Invalid

Missing Error Message in `require` Check

Summary

The _extractPeriodFromProof function in the contract includes a require(slot.exists) check without an accompanying error message. While this does not introduce a security vulnerability, it reduces the clarity of transaction failures, making it harder to diagnose issues during debugging or emergencies.

Affected Code: _extractPeriodFromProof


Impact

The lack of an error message in the require statement has the following implications:

  • Troubleshooting Difficulty: When the condition fails, the transaction reverts with a generic error ("Transaction reverted without a reason string"). This makes it challenging to identify the root cause of the failure.

  • Emergency Response: During exploits or unexpected behavior, the absence of informative error messages can delay critical fixes, wasting valuable time.

  • User Experience: Users interacting with the contract may be confused by generic revert messages, leading to a poor experience.


Recommendations

  1. Add an Error Message:

    • Update the require statement to include a descriptive error message:

      require(slot.exists, "Period slot does not exist in proof");

Reference

This issue aligns with the finding documented in the following reference:

Updates

Lead Judging Commences

0xnevi Lead Judge 3 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

[invalid] finding-error-can-be-more-explicit

Informational, non-acceptable severity given it has arguably no security impact

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.