DeFiLayer 1Layer 2
14,723 OP
View results
Submission Details
Severity: low
Valid

Missing event emission for key state change

Summary

In function update_profit_max_unlock_time user with role `UNLOCK_TIME_VERIFIER` update value of profit_max_unlock_time variable and last_block_number. But after that, event has not emit.

Vulnerability Details

Function update_profit_max_unlock_time change state of contract. But event has not emit.

Impact

Event emission in setter function provide an essential audit trail on the blockchain, allowing users, auditors, and developers to track when and how key parameters are modified.

Without this event, it becomes challenging to trace changes, which may impact transparency and debugging.

Tools Used

Manual review

Recommendations

Emit event, when function update_profit_max_unlock_time called.

Updates

Lead Judging Commences

0xnevi Lead Judge 5 months ago
Submission Judgement Published
Validated
Assigned finding tags:

finding-missing-event-emission-profit_max_unlock_time

I believe low severity to be appropriate here, events could be used to be more explicit for the upcoming effects on price for changes in max unlock time, similar to as included in `update_price` with the `PriceUpdate` event

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.