Inheritable Smart Contract Wallet

Summary

This review focuses on identifying and addressing the missing events in the NFTFactory smart contract. The contract allows the creation and burning of ERC721 tokens (estates) with metadata storage. The primary concern is the absence of events for minting and burning operations, which reduces transparency and makes it difficult to monitor the contract's activity from front-end applications.

Vulnerability Details

createEstate and burnEstate functions do not emit events, which can make it difficult for front-end applications to track changes in the contract state.

Lack of events reduces transparency and makes it harder to monitor the contract's activity.

Impact

Reduced Transparency : Without events, front-end applications cannot easily track when new estates are created or existing ones are burned.

Difficulty in Monitoring : Developers and users rely on events to understand the state changes in the contract, and their absence can lead to inefficiencies and potential security concerns.

Tools Used

Manual Code Review

Recommendations

• Action : Emit events in the createEstate and burnEstate functions to provide transparency and facilitate monitoring.

• Implementation :

  1. Define the events EstateCreated and EstateBurned.

  2. Emit these events in the respective functions.