Lack of control over duplicate beneficiaries
Summary
There is no mechanism implemented in this function to prevent duplicate addresses from being added. This means that you can add an address to the list multiple times, which may cause problems in the contract logic (such as sharing assets across other functions).
Vulnerability Details
In the addBeneficiary function, no check is made for duplicate beneficiaries, which causes duplicate beneficiaries to be entered, which effectively causes unfair distribution.
Impact
Incorrect division of property due to the wrong number of beneficiaries
Tools Used
manual review
Recommendations
To avoid duplicate beneficiaries, you can add a mapping and check it before pushing.
Rewards breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.