Submission Details
Severity:
Ineffective Access Control in `onlyBeneficiaryWithIsInherited` Modifier
Summary: The onlyBeneficiaryWithIsInherited modifier fails to restrict access to beneficiaries when isInherited is true, allowing any address to call protected functions like buyOutEstateNFT and appointTrustee
Vulnerability Details: The modifier uses a while loop with a flawed termination condition i < beneficiaries.length + 1. If a non-beneficiary calls a function with this modifier, the loop will run past the end of the array, causing an out-of-bounds error rather than a proper authentication check
Impact : Medium. Relying on out-of-bounds errors for authentication is poor design and could be vulnerable to changes in Solidity's behavior. This creates an unconventional authentication pattern that may be misunderstood during code maintenance
Tools Used
Recommendations :
modifier onlyBeneficiaryWithIsInherited() {
require(isInherited, "Not yet inherited");
bool isBeneficiary = false;
for (uint256 i = 0; i < beneficiaries.length; i++) {
if (msg.sender == beneficiaries[i]) {
isBeneficiary = true;
break;
}
}
require(isBeneficiary, "Not a beneficiary");
_;
}
Rewards breakdown
nSLOC
211This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.