Submission Details
Severity:
The 'createEstateNFT' function doesnt reset deadline every transaction the owner does
Summary
The 'createEstateNFT' function doesnt reset deadline every transaction the owner does
Vulnerability Details
In Docs it says "EVERY transaction the owner does with this contract must reset the 90 days timer" but it isnt not True because The 'createEstateNFT' function should be reseting 90 days timer
function createEstateNFT(string memory _description, uint256 _value, address _asset) external onlyOwner {
uint256 nftID = nft.createEstate(_description);
nftValue[nftID] = _value;
assetToPay = _asset;
// @audit-issue 'createEstateNFT' isnt reseting 90 days timer with setDeadline();
}
Impact
the documentation contradicts itself also it is wrong logic
Tools Used
Manual Review ^^
Recommendations
Consider adding 'setDeadline' to the final line of 'createEstateNFT' function
Updates
Lead Judging Commences
0xtimefliez 5 months ago
Submission Judgement Published Assigned finding tags:
functions do not reset the deadline
Rewards breakdown
nSLOC
211This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.