Submission Details
Severity:
Incorrect return value in createEstate(), NFTFactory.sol
Summary
The createEstate function returns the incorrect variable uint256 itemID instead of ID.
Vulnerability Details
The function defines ID as a _incrementCounter for minting an NFT but declares itemID as the return variable. However, itemID is never assigned a value, and the function directly returns ID, leading to an inconsistency in the function signature.
function createEstate(string memory description) external onlyInheritanceManager returns (uint256 itemID) {
uint256 ID = _incrementCounter();
_mint(msg.sender, ID);
_setTokenURI(ID, description);
return ID;
}
Impact
Incorrect return value
Misleading developers and users
Tools Used
Manual review
Recommendations
Fixed code:
function createEstate(string memory description) external onlyInheritanceManager returns (uint256) {
uint256 ID = _incrementCounter();
_mint(msg.sender, ID);
_setTokenURI(ID, description);
return ID;
}
Rewards breakdown
nSLOC
211This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.