Beginner FriendlySolidity
100 EXP
View results
Submission Details
Severity: medium
Valid

Timer Is Not Reset In InheritanceManager::removeBeneficiary Which Breaks Core Functionallity Of The Contract

Summary: The 90 days deadline reset isn't present in InheritanceManager::removeBeneficiary which breaks the core assumption of the contract

Vulnerability Details: The 90 days deadline is not set in InheritanceManager::removeBeneficiary which breaks the core assumption of the contract that all functions called by the owner will reset the 90 days deadline

//@audit --> Function called by owner doesn't reset the 90 days timer
function removeBeneficiary(address _beneficiary) external onlyOwner {
uint256 indexToRemove = _getBeneficiaryIndex(_beneficiary);
delete beneficiaries[indexToRemove];
}

Impact: This breaks the core functionality of the contract that every transaction carried out by the owner would reset the 90 days timer

Tools Used: Foundry

Recommendations: Implement the _setDeadline on InheritanceManager::removeBeneficiary

//@audit --> Added Deadline reset
_setDeadline();
Updates

Lead Judging Commences

0xtimefliez Lead Judge 6 months ago
Submission Judgement Published
Validated
Assigned finding tags:

functions do not reset the deadline

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.