Submission Details
Severity:
Incorrect Handling of Zero Balance in withdrawInheritedFunds()
Summary
The function does not check if the contract has a non-zero balance before attempting withdrawals.
Vulnerability Details
If the contract has a zero balance, the function will still attempt to distribute funds, wasting gas.
Impact
Users may pay gas fees for transactions that do nothing.
Tools Used
Manual rEview
Recommendations
Add a check to ensure the contract has a non-zero balance:
if (_asset == address(0)) {
require(address(this).balance > 0, "No Ether balance");
} else {
require(IERC20(_asset).balanceOf(address(this)) > 0, "No token balance");
}
Rewards breakdown
nSLOC
211This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.