Beginner FriendlySolidity
100 EXP
View results
Submission Details
Severity: medium
Invalid

Inconsistent Deadline Logic in `inherit()`

Summary

The inherit function sets isInherited = true for multiple beneficiaries but does not set a deadline, while it sets a deadline for a single beneficiary. This inconsistency could allow withdrawals to happen immediately for multiple beneficiaries.

Vulnerability Details

  • For one beneficiary, the deadline is set using _setDeadline().

  • For multiple beneficiaries, no deadline is set, which could allow withdrawals to happen immediately.

Impact

  • Inconsistent Behavior: Withdrawals for multiple beneficiaries could happen immediately, while withdrawals for a single beneficiary are delayed.

  • Security Risk: Funds could be withdrawn prematurely for multiple beneficiaries.

Recommendations

  • Set the deadline for all cases (single or multiple beneficiaries) in the inherit function

Updates

Lead Judging Commences

0xtimefliez Lead Judge 6 months ago
Submission Judgement Published
Invalidated
Reason: Design choice

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.