Summary

The InheritanceManager:assetToPay variable is overridden each time a call to InheritanceManager:createEstateNFT is called. If you create one NFT to be paid in DAI and a second to be paid in LINK, attempting to call InheritanceManager:buyOutEstateNFT for the first NFT would result in LINK being paid out instead of DAI.

Vulnerability Details

A test to see that the assetToPay gets overwritten if createEstateNFT gets called more than once.

Impact

Beneficiaries would be paid an incorrect token which could be valued differently than the intended assetToPay token.

Tools Used

Remix

Recommendations

Add a new mapping to the Trustee contract to keep track of each assetToPay for each NFT mapping(uint256 NftIndex => address assetToPay) nftAssetToPay;