Submission Details
Severity:
`InheritanceManager::setDeadline` is not initialised in the constructor which means the inactivity timer does not start.
Description
_setDeadline is not initialised in the constructor of the contract, meaning deadline is 0 until an action with _setDeadline is called by the owner, which would set it to block.timestamp + TIMELOCK.
Impact
The protocol will not function as expected or as intended.
Proof of Concept
Add the following code to InheritanceManagerTest.t.sol:
function test_deadlineNotSet() public {
assertEq(0, im.getDeadline());
}
The result should be a number along the lines of block.timestamp + 7776000, however the assertion above passes.
Tools Used
Manual review, Foundry
Recommended Mitigation
Add the following line to the constructor to ensure the deadline is set correctly.
constructor() {
owner = msg.sender;
nft = new NFTFactory(address(this));
+ _setDeadline();
}
Updates
Lead Judging Commences
0xtimefliez 9 months ago
Submission Judgement Published Assigned finding tags:
constructor does not initialize deadline
Rewards breakdown
nSLOC
211This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.