Submission Details
Severity:
The `InheritanceManager::contractInteractions` function does not reset deadline after being called
Summary
When the owner calls the InheritanceManager::contractInteractionsfunction the deadlineis not reset making it possible for funds to be claimed by beneficiaries before the deadline passes.
Vulnerability Details
Because the deadlineis not reset in this function it's possible to claim funds before the intended deadlinepasses.
Tools Used
Manual code review
Recommendations
Reset the deadline in the contractInteractionsfunction:
function contractInteractions(address _target, bytes calldata _payload, uint256 _value, bool _storeTarget)
external
nonReentrant
onlyOwner
{
(bool success, bytes memory data) = _target.call{value: _value}(_payload);
require(success, "interaction failed");
if (_storeTarget) {
interactions[_target] = data;
}
+ _setDeadline()
}
Updates
Lead Judging Commences
0xtimefliez 9 months ago
Submission Judgement Published Assigned finding tags:
functions do not reset the deadline
constructor does not initialize deadline
Appeal created
0xtimefliez 9 months ago
Submission Judgement Published Assigned finding tags:
functions do not reset the deadline
Rewards breakdown
nSLOC
211This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.