Submission Details
Severity:
uneven beneficiary split when added multiple times
Summary:
Current setup allows for an address/beneficiery to be added multiple times
Vulnerability Details
function test_addBeneficiaryMultipleTimes() public {
vm.deal(address(im), 10e18);
vm.startPrank(owner);
im.addBeneficiery(user1);
im.addBeneficiery(user1);
im.addBeneficiery(user1);
im.addBeneficiery(user1);
im.addBeneficiery(user2);
im.removeBeneficiary(user1);
vm.warp(block.timestamp + 92 days);
im.inherit();
im.withdrawInheritedFunds(address(0));
vm.stopPrank();
console.log("balance user1", user1.balance);
}
Impact
with this setup the user1 and user2 would incorrectly be considered that amountPerBeneficiary is 2 eth, while it should be 5 eth each, since one of the addresses is present multiple times. user2 share can be furtehr diluted if even more repeating instances of user1 occur.
Tools Used
foundry
Recommendations:
Check and make sure in addBeneficeirysame addresses cannot be added multiple times
Rewards breakdown
nSLOC
211This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.