Submission Details
Severity:
Security Vulnerabilities
Summary
Access Control Weaknesses
Vulnerability Details
The onlyBeneficiaryWithIsInherited modifier uses a while loop that can go out of bounds (i < beneficiaries.length + 1).
Impact
This can potentially cause undefined behavior or revert the transaction.
Tools Used
/**
* @dev this while loop will revert on array out of bounds if not
* called by a beneficiary.
*/
modifier onlyBeneficiaryWithIsInherited() {
uint256 i = 0;
while (i < beneficiaries.length + 1) {
if (msg.sender == beneficiaries[i] && isInherited) {
break;
}
i++;
}
_;
}
Recommendations
Fix the onlyBeneficiaryWithIsInherited modifier to prevent out-of-bounds errors
modifier onlyBeneficiaryWithIsInherited() {
uint256 i = 0;
while (i < beneficiaries.length) {
if (msg.sender == beneficiaries[i] && isInherited) {
_;
return;
}
i++;
}
revert NotOwner(msg.sender);
}
Rewards breakdown
nSLOC
211This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.