Beginner FriendlySolidity
100 EXP
View results
Submission Details
Severity: medium
Valid

unauthorized access to funds before intended timelock period.

Summary

We are missing _setDeadline on multiple places. This is a direct misalign with protocol commitments for time lock. Hence some owner actions are not triggering time lock

Vulnerability Details

_setDeadline is not triggered on:

  • contractInteractions

  • createEstateNFT

  • removeBeneficiary

  • withdrawInheritedFunds, inherit, getters when triggered by owner

Impact

violates a critical feature the protocol pretends to have.

The removeBeneficiary function doesn't reset the deadline after modifying beneficiaries, which could allow premature inheritance claims. Specifically in removeBeneficiary could have impact.

Tools Used

foundry

Recommendation: Add _setDeadline() call in removeBeneficiary:

function removeBeneficiary(address _beneficiary) external onlyOwner {
uint256 indexToRemove = _getBeneficiaryIndex(_beneficiary);
delete beneficiaries[indexToRemove];
_setDeadline();
}
Updates

Lead Judging Commences

0xtimefliez Lead Judge 3 months ago
Submission Judgement Published
Validated
Assigned finding tags:

functions do not reset the deadline

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.