Beginner FriendlySolidity
100 EXP
View results
Submission Details
Severity: medium
Valid

Function "contractInteractions" does not reset 90 days timer

Summary

Function contractInteractions does not reset 90 days timer and thus violates the core assumption of the contract.

Vulnerability Details

As per the project documentation, every transaction the owner does with this contract must reset the 90 days timer. However, function contractInteractions does not reset the timer.

Impact

The timer is not reset after the owner makes a transaction, thus the contract can be inherited after less than 90 days after the transaction.

Tools Used

Manual review

Recommendations

Add _setDeadline(); at the end of function contractInteractions:

function contractInteractions(address _target, bytes calldata _payload, uint256 _value, bool _storeTarget)
external
nonReentrant
onlyOwner
{
(bool success, bytes memory data) = _target.call{value: _value}(_payload);
require(success, "interaction failed");
if (_storeTarget) {
interactions[_target] = data;
+ _setDeadline();
}
Updates

Lead Judging Commences

0xtimefliez Lead Judge 9 months ago
Submission Judgement Published
Validated
Assigned finding tags:

functions do not reset the deadline

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!