Inheritable Smart Contract Wallet
First Flight #35
Beginner FriendlySolidity
100 EXP
View results
Previous Next
Submission Details
Severity: medium
Valid

Missing Deadline Update in Critical Functions

ekene

Summary:
The deadline is not updated in functions such as InheritanceManager::createEstateNFT and InheritanceManager::contractInteractions, potentially leading to premature asset inheritance.

Vulnerability Details:
Failure to update the deadline after these transactions can make an account appear dormant even when it is active, causing unintended behaviors.

Code Example
function contractInteractions(address _target, bytes calldata _payload, uint256 _value, bool _storeTarget)
external
nonReentrant
onlyOwner
{
(bool success, bytes memory data) = _target.call{value: _value}(_payload);
require(success, "interaction failed");
if (_storeTarget) {
interactions[_target] = data;
}
}

Impact:
High – Incorrect deadline handling may trigger premature inheritance events.

Tools Used:
slither, aderyn, foundry

Recommendations:
Incorporate a deadline update (e.g., by calling _setDeadline()) at the end of these functions.

Diff Recommendation
function contractInteractions(address _target, bytes calldata _payload, uint256 _value, bool _storeTarget)
external
nonReentrant
onlyOwner
{
(bool success, bytes memory data) = _target.call{value: _value}(_payload);
require(success, "interaction failed");
if (_storeTarget) {
interactions[_target] = data;
}
​
+ _setDeadline();
}
Updates

Lead Judging Commences

0xtimefliez Lead Judge 9 months ago
Submission Judgement Published
Validated
Assigned finding tags:

functions do not reset the deadline

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!