Inheritable Smart Contract Wallet

Summary

Function contractInteractions overwrites data for a contract if there are stored interactions with the same contract.

Vulnerability Details

When function InheritanceManager::contractInteractions is called with _storeTarget set to true, the data is stored in the interactions mapping. The issue here is that if there are several interactions with the same contract, each new interaction overrides the data from the previous interactions.

Impact

Some interactions with other contracts will be lost if there are new interactions with the same contract.

Tools Used

Manual review

Recommendations

Change type of interactions to mapping(address protocol => bytes[]) and store all interactions for every contract.