Beginner FriendlySolidity
100 EXP
View results
Submission Details
Severity: low
Invalid

Non-Used Functions in Trustee Contract

Summary
The setNftValue, getNftValue, and getAssetToPay functions in the Trustee contract are marked as public, but they are either not intended to be called by external users or are missing the appropriate modifier for external access. These functions are currently unused, so if they are unnecessary, they should be removed. Otherwise, they should be assigned the correct visibility modifier. If I understand the contract correctly, they should likely be external.

Vulnerability Details
These functions are restricted by the onlyTrustee modifier, but their public visibility could lead to unintended behavior or misuse.

Impact

Unused functions increase contract size, leading to higher deployment costs and unnecessary complexity

Tools Used
Manual review

Recommendations
The onlyTrustee modifier restricts access to these functions, but they are not used anywhere. If they are unnecessary, consider removing them.

Updates

Lead Judging Commences

0xtimefliez Lead Judge 9 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!