Inheritable Smart Contract Wallet

Summary

The onlyBeneficiaryWithIsInherited modifier in the InheritanceManager contract uses a while loop to iterate over the beneficiaries array. If the array grows too large, this could lead to a denial-of-service (DoS) attack due to excessive gas consumption. It could also cause an out-of-bounds error if no match is found.

Vulnerability Details

• Code:

  modifier onlyBeneficiaryWithIsInherited() {

  uint256 i = 0;

  while (i < beneficiaries.length + 1) {

  if (msg.sender == beneficiaries[i] && isInherited) {

  break;

  }

  i++;

  }

  _;

  }

Issue: A large beneficiaries array could make the contract unusable due to high gas costs

Impact

A DoS attack could make the contract unusable.

Tools Used

Manual review

Recommendations

Use a mapping instead of array:

Change while (i < beneficiaries.length + 1) to while (i < beneficiaries.length) to prevent out-of-bounds errors.