Beginner FriendlySolidity
100 EXP
View results
Submission Details
Severity: high
Valid

Division Before Multiplication in buyOutEstateNFT

Summary

The buyOutEstateNFT function in the InheritanceManager contract performs division before multiplication, which could lead to precision loss due to integer division in Solidity.

Vulnerability Details

  • Code:

    uint256 finalAmount = (value / divisor) * multiplier;

Impact

Performing division before multiplication could result in precision loss.

Tools Used

Manual review

Recommendations

Perform multiplication before division to minimize precision loss:

uint256 finalAmount = (value * multiplier) / divisor;
Updates

Lead Judging Commences

0xtimefliez Lead Judge 9 months ago
Submission Judgement Published
Validated
Assigned finding tags:

buyOutNFT has wrong denominator

truncation of integers

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!