Inheritable Smart Contract Wallet

Summary

The nonReentrant modifier in the InheritanceManager contract uses transient storage (tload and tstore) to prevent reentrancy. However, the implementation is incorrect, which could lead to reentrancy vulnerabilities.

Vulnerability Details

• Code:

  modifier nonReentrant() {

  assembly {

  if tload(1) { revert(0, 0) }

  tstore(0, 1)

  }

  _;

  assembly {

  tstore(0, 0)

  }

  }

Impact

The modifier uses transient storage (tload and tstore) incorrectly. Specifically:

• The code checks slot 1 (tload(1)) but writes to and clears slot 0 (tstore(0, 1) and tstore(0, 0)).

• Since slot 1 is never written to, tload(1) always returns 0, and the reentrancy guard never triggers.

Tools Used

Manual review

Recommendations