Submission Details
Severity:
`buyOutEstateNFT` failed from early return
Summary
buyOutEstateNFT failed from early return. resulting in fund transferred to contract but it doesn't burn
Vulnerability Details
In the loop in buyOutEstateNFT to skip beneficary that send the fund, the contract use return instead of continue which ended the execution before burning NFT. If beneficary is in front of array then fund will not send to others too.
Impact
High, as business logic is completely wrong.
Tools Used
Foundry
Recommendations
Change into
for (uint256 i = 0; i < beneficiaries.length; i++) {
if (msg.sender == beneficiaries[i]) {
-- return;
++ continue;
} else {
IERC20(assetToPay).safeTransfer(beneficiaries[i], finalAmount / divisor);
}
}
Updates
Lead Judging Commences
0xtimefliez 6 months ago
Submission Judgement Published Assigned finding tags:
buyOutNFT has return instead of continue
Rewards breakdown
nSLOC
211This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.