Submission Details
Severity:
DOS - Should limit the number of beneficiaries to not overflow the max gas limit when looping
Summary
The number of beneficiaries should be limited to not overflow the max gas limit when looping
Vulnerability Details
/**
* @dev adds a beneficiary for possible inheritance of funds.
* @param _beneficiary beneficiary address
*/
function addBeneficiery(address _beneficiary) external onlyOwner {
beneficiaries.push(_beneficiary);
_setDeadline();
}
We can see that there is no limitation to the number of beneficiaries. We can add as many as we want.
When looping the beneficiaries, if there is too much of them the transaction will run out of gas.
Resulting in a Deny Of Service.
Impact
Deny Of Service (DOS) if the number of beneficiaries is too high. The transaction won't go through when looping the beneficiaries.
Tools Used
Github, manual review.
Recommendations
Add some restrictions/limits to the number of beneficiaries that can be added.
Rewards breakdown
nSLOC
211This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.