Beginner FriendlySolidity
100 EXP
View results
Submission Details
Severity: medium
Valid

Timer Is Not Reset In InheritanceManager::contractInteractions Which Breaks Core Functionality Of The Contract

Summary: The 90 days timer reset isn't present in InheritanceManager::contractInteractions which breaks the core assumption that all transactions carried out by the owner should reset the 90 days timer.

Vulnerability Details: The 90 days timer reset isn't present in InheritanceManager::contractInteractions which breaks the core assumption that all transactions carried out by the owner should reset the 90 days timer. The vulnerable code:

//@audit --> Function called by owner doesn't reset the 90 days timer
function contractInteractions(address _target, bytes calldata _payload, uint256 _value, bool _storeTarget)
external
nonReentrant
onlyOwner
{
(bool success, bytes memory data) = _target.call{value: _value}(_payload);
require(success, "interaction failed");
if (_storeTarget) {
interactions[_target] = data;
}
}

Impact: This breaks core functionality of the contract.

Tools Used: Foundry

Recommendations: Implement _setDeadline() to InheritanceManager::contractInteractions

//@audit --> Added Deadline reset
_setDeadline();
Updates

Lead Judging Commences

0xtimefliez Lead Judge 6 months ago
Submission Judgement Published
Validated
Assigned finding tags:

functions do not reset the deadline

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.