Beginner FriendlySolidity
100 EXP
View results
Submission Details
Severity: low
Invalid

Summary

These all are related to the gas or informational

-> we can mark the inheritanceManager in NFTFactory as immutable as it was assigned only once

-> And in all loopings in this contract , it was using fron the storagevariable.length instead if caching it

-> In docs it was mentioned that _setDeadline need to call at coontract creation but it was not , with current login it wont effect the contract , but in future to if we change the logic around the deadline dependency then this will be a problem

Recommendations

-> Need to use cached data when looping based on the length of the array
-> need to implement based on the docs specified or need to upadate the docs to the latest one

Updates

Lead Judging Commences

0xtimefliez Lead Judge 10 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!