Submission Details
Severity:
Premature Return in NFT Buyout Loop
Summary
The buyOutEstateNFT loop returns immediately upon finding the caller, skipping payments to other beneficiaries.
Vulnerability Details
The loop uses return inside the conditional, terminating execution after transferring to the first non-caller beneficiary.
Impact
Most beneficiaries do not receive their share, violating equitable distribution.
Tools Used
Manual review.
Recommendations
Remove the return statement and use continue to skip the caller:
for (uint256 i = 0; i < beneficiaries.length; i++) {
if (beneficiaries[i] == msg.sender) continue;
IERC20(assetToPay).safeTransfer(beneficiaries[i], finalAmount / (divisor - 1));
}
Updates
Lead Judging Commences
0xtimefliez 6 months ago
Submission Judgement Published Assigned finding tags:
buyOutNFT has return instead of continue
Rewards breakdown
nSLOC
211This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.