Beginner FriendlySolidity
100 EXP
View results
Submission Details
Severity: low
Invalid

Lack of Input Validation in Critical Functions

Summary

Functions like addBeneficiary and createEstateNFT lack checks for zero addresses or duplicate entries.

Vulnerability Details

  • addBeneficiary allows adding address(0) or existing beneficiaries.

  • createEstateNFT does not validate _asset as a valid ERC20 contract.

Impact

Potential governance issues or failed transactions due to invalid inputs.

Tools Used

Manual review.

Recommendations

Add checks:

require(_beneficiary != address(0), "Invalid address");
require(!beneficiaries.contains(_beneficiary), "Duplicate beneficiary");

Use OpenZeppelin’s Address.isContract for _asset.

Updates

Lead Judging Commences

0xtimefliez Lead Judge 6 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.