Submission Details
Severity:
modifier onlyBeneficiaryWithIsInherited has a logic flaw
Summary
when msg.sender is not in beneficiaries or isInherited is false, modifier onlyBeneficiaryWithIsInherited shoud revert,but there is no revert.
Vulnerability Details
modifier onlyBeneficiaryWithIsInherited() {
uint256 i = 0;
while (i < beneficiaries.length + 1) {
if (msg.sender == beneficiaries[i] && isInherited) {
break;
}
i++;
}
_;
}
Impact
anyone can bypass the modifier
Tools Used
Recommendations
modifier onlyBeneficiaryWithIsInherited() {
uint256 i = 0;
while (i < beneficiaries.length + 1) {
if (msg.sender == beneficiaries[i] && isInherited) {
break;
}
i++;
}
revert("msg.sender is not in beneficiaries or isInherited is false") //
_;
}
Updates
Rewards breakdown
nSLOC
211This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.