Beginner FriendlySolidity
100 EXP
View results
Submission Details
Severity: medium
Invalid

Unitilized Storage variable

Summary

in the src/InheritanceManager.sol contract, the address[] beneficiaries` variable isn't set to a value

Vulnerability Details

```

NFTFactory nft;
address owner;
** address[] beneficiaries;
uint256 deadline;
bool isInherited = false;
mapping(address protocol => bytes) interactions;
uint256 public constant TIMELOCK = 90 days;

Impact

A potential DOS attack which could prevent the contract from working altogether could potentially happen which is very likely as being a benefeciary is a requirement for withdrawal

Tools Used

Manual review

Recommendations

The number of beneficiaries in the address[] beneficiaries should be set to a finite number in the constructor to prevent a potential DOS attack especially when it is being looped over as it is an array

for example;

constructor() {
+ beneficiaries = 5;
owner = msg.sender;
nft = new NFTFactory(address(this));
}
Updates

Lead Judging Commences

0xtimefliez Lead Judge 4 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
0xtimefliez Lead Judge 4 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.