Beginner FriendlySolidity
100 EXP
View results
Submission Details
Severity: medium
Valid

Don't reset deadline in function removeBeneficiary() lead wrong deadline

Summary

Deadline is not be updated when removing beneficiary in function removeBeneficiary() lead wrong deadline

Vulnerability Details

Code:

function removeBeneficiary(address _beneficiary) external onlyOwner {
uint256 indexToRemove = _getBeneficiaryIndex(_beneficiary);
delete beneficiaries[indexToRemove];
// No update deadline
}

Impact

Wrong deadline - high
likelihood: medium

Tools Used

Recommendations

function removeBeneficiary(address _beneficiary) external onlyOwner {
uint256 indexToRemove = _getBeneficiaryIndex(_beneficiary);
delete beneficiaries[indexToRemove];
+ _setDeadline();
}
Updates

Lead Judging Commences

0xtimefliez Lead Judge 3 months ago
Submission Judgement Published
Validated
Assigned finding tags:

functions do not reset the deadline

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.