The Fund struct and set_deadline
function use dealine_set instead of the intended deadline_set. This typographical error is inconsistent with the variable’s purpose and could confuse developers or lead to accidental misuse in future updates.
Location:
Fund struct: pub dealine_set: bool
set_deadline function: if fund.dealine_set
Description: The field is meant to track whether a deadline has been set for the fund but is misspelled as dealine_set instead of deadline_set. The logic still works because the typo is consistent, but it deviates from the intended naming convention.
** Confusion**: Developers reading or maintaining the code might misinterpret the field’s purpose due to the typo.
Future Bugs: If the typo is “fixed” in one place but not others, it could introduce logic errors (e.g., referencing deadline_set instead of dealine_set).
Manual Code Review: Identified during analysis of the contract’s logic and struct definitions.
Fix Typo: Rename dealine_set to deadline_set in both the Fund struct and set_deadline function
This is strong informational finding, there is no impact for the protocol. The variable is the same on all places.
The contest is live. Earn rewards by submitting a finding.
This is your time to appeal against judgements on your submissions.
Appeals are being carefully reviewed by our judges.